GHSA-m6w8-fq7v-ph4m – @openzeppelin/contracts

Package

Manager: npm
Name: @openzeppelin/contracts
Vulnerable Version: >=4.3.0 <4.4.2

Severity

Level: Medium

CVSS v3.1: CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N/E:U/RL:O/RC:C

CVSS v4.0: CVSS:4.0/AV:L/AC:L/AT:N/PR:N/UI:N/VC:N/VI:L/VA:N/SC:N/SI:N/SA:N

EPSS: N/A pctlN/A

Details

GovernorCompatibilityBravo incorrect ABI encoding may lead to unexpected behavior ### Impact The `GovernorCompatibilityBravo` module may lead to the creation of governance proposals that execute function calls with incorrect arguments due to bad ABI encoding. This happens if the proposal is created using explicit function signatures, e.g. a proposal to invoke the function `foo(uint256)` is created as `propose([target], [0], ["foo(uint256)"], ["0x00..01"])`. If the function selector is provided as part of the encoded proposal data the issue is not present, e.g. the same proposal is created as `propose([target], [0], ["0x2fbebd3800..01"])`, where `2fbebd38` is the function selector. We've assessed the instances of this contract found on chain, and did not find any occurrence of this bug in the past. Proposal creation through Tally or OpenZeppelin Defender is not affected. The core `Governor` contract on its own is not affected. ### Patches A fix is included in version v4.4.2 of `@openzeppelin/contracts` and `@openzeppelin/contracts-upgradeable`. ### Workarounds Do not create proposals using explicit function signatures. Instead, use the `propose` function without the `signatures` argument, and create the proposal using the fully ABI-encoded function call including the function selector in the `calldatas` argument as explained above. ### References https://github.com/OpenZeppelin/openzeppelin-contracts/issues/3099 ### Credits This issue was identified and reported by @GeraldHost. ### For more information If you have any questions, comments, or need assistance regarding this advisory, email us at security@openzeppelin.com. To submit security reports please use [our bug bounty on Immunefi](https://immunefi.com/bounty/openzeppelin/).

Metadata

Created: 2022-01-13T16:09:36Z
Modified: 2022-01-12T21:38:27Z
Source: https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2022/01/GHSA-m6w8-fq7v-ph4m/GHSA-m6w8-fq7v-ph4m.json
CWE IDs: []
Alternative ID: N/A
Finding: F113
Auto approve: 1