GHSA-ff5x-w9wg-h275 – vp-toolkit

Package

Manager: npm
Name: vp-toolkit
Vulnerable Version: >=0 <0.2.2

Severity

Level: High

CVSS v3.1: CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:N/I:L/A:N/E:P/RL:O/RC:C

CVSS v4.0: CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:N/VI:L/VA:N/SC:N/SI:N/SA:N

EPSS: N/A pctlN/A

Details

Holder can generate proof of ownership for credentials it does not control in vp-toolkit ### Impact The [`verifyVerifiablePresentation()`](https://github.com/rabobank-blockchain/vp-toolkit/blob/master/src/service/signers/verifiable-presentation-signer.ts#L97) method check the cryptographic integrity of the Verifiable Presentation, but it does not check if the [`credentialSubject.id`](https://github.com/rabobank-blockchain/vp-toolkit-models/blob/develop/src/model/verifiable-credential.ts#L150) DID matches the signer of the VP proof. The **verifier** is impacted by this vulnerability. ### Patches Patch will be available in version 0.2.2. ### Workarounds - Compute the address out of the `verifiablePresentation.proof.n.verificationMethod` using `getAddressFromPubKey()` from `crypt-util@0.1.5` and match it with the `credentialSubject.id` address from the credential. ### References [Github issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14) ### For more information If you have any questions or comments about this advisory: * Discuss in the existing [issue](https://github.com/rabobank-blockchain/vp-toolkit/issues/14) * [Contact me](https://github.com/rabomarnix)

Metadata

Created: 2020-03-06T01:15:46Z
Modified: 2020-02-28T16:38:18Z
Source: https://github.com/github/advisory-database/blob/main/advisories/github-reviewed/2020/03/GHSA-ff5x-w9wg-h275/GHSA-ff5x-w9wg-h275.json
CWE IDs: []
Alternative ID: N/A
Finding: F204
Auto approve: 1