logo

Database

Insecure session management In ash_authentication

Description

AshAuthentication log_out_everywhere leaves sessions valid after a password reset or non-atomic password change

Summary

Improper Session Invalidation after Authentication Credential Change vulnerability in team-alembic ash_authentication allows an attacker holding a victim's session token to stay signed in after the victim resets or changes their password.

With apply_on_password_change? true, AshAuthentication.AddOn.LogOutEverywhere.Transformer adds OnPasswordChange to update actions as a global change guarded by where: changing(hashed_password). That condition is evaluated before the action's before_action hooks run, but AshAuthentication.Strategy.Password.HashPasswordChange sets the new hash in a before_action hook, so for every non-atomic password change the condition is false and the user's stored tokens are not revoked. The generated password reset action and the installer's change_password action are both non-atomic.

This issue affects ash_authentication: from 4.5.0 before 4.15.1 and from 5.0.0-rc.0 before 5.0.0-rc.16.

Configurations

The log_out_everywhere add-on sets apply_on_password_change? true, as mix ash_authentication.install writes, and the password is changed through a non-atomic update action, which includes the generated password reset action and the installer's change_password action. The attacker must already hold one of the victim's session tokens.

Mitigation

Update Impact

Minimal update. May introduce new vulnerabilities or breaking changes.

Ecosystem
Component
Affected version
Patched versions